LDEV-6164 register BonCode event source to prevent midnight crash#39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Boncode AJP connector crashes at exactly midnight when logging is enabled and the Windows Event Log source "BonCodeConnector" is not registered. The crash leaves IIS unresponsive until the app pool is restarted.
BonCodeConnectorevent source viaNew-EventLogafter Boncode connector installinstalliismatrix flag to Windows CI (falseandtrue) so we test both with and without IISRoot cause
Every midnight, Boncode reinitialises and logs its version string.
EventLog.SourceExists()throws because the IIS worker process can't search the Security/State event logs. The exception bubbles intoConnectionError()which hits a null ref onp_NetworkStream(never assigned). Boncode enters a broken state permanently.References
Test plan
test-windows (installiis: false)passes (existing behaviour unchanged)test-windows (installiis: true)passes (IIS installed, Boncode configured, event source registered)BonCodeConnectoris registered