Skip to content

DM-54543: Turn off negative polarity detections for background measurement. #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erykoff wants to merge 2 commits into from
Closed

DM-54543: Turn off negative polarity detections for background measurement. #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e92813c
Turn off negative polarity detections when doing background re-estima…
erykoff Apr 16, 2026
c114ea1
Change to positive polarity for adaptive threshold backgrounds.
erykoff Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/lsst/meas/algorithms/adaptive_thresholds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ def run(self, table, exposure, initialThreshold=None, initialThresholdMultiplier
adaptiveDetectionConfig.reEstimateBackground = False
adaptiveDetectionConfig.doTempWideBackground = True
adaptiveDetectionConfig.tempWideBackground.binSize = 512
adaptiveDetectionConfig.thresholdPolarity = "both"
adaptiveDetectionConfig.thresholdPolarity = "positive"
self.log.info("Using adaptive detection with thresholdValue = %.2f and multiplier = %.1f",
adaptiveDetectionConfig.thresholdValue,
adaptiveDetectionConfig.includeThresholdMultiplier)
Expand Down
2 changes: 1 addition & 1 deletion python/lsst/meas/algorithms/detection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ def applyThreshold(self, middle, bbox, factor=1.0, factorNeg=None):
self.config.minPixels
)
results.positive.setRegion(bbox)
if self.config.reEstimateBackground or self.config.thresholdPolarity != "positive":
if self.config.thresholdPolarity != "positive":
results.negativeThreshold = self.makeThreshold(middle, "negative", factor=factorNeg)
results.negative = afwDet.FootprintSet(
middle,
Expand Down
Loading