fix: call onResult callback for failed rows in BatchEvaluator#19
Merged
fix: call onResult callback for failed rows in BatchEvaluator#19
Conversation
The onResult callback was only invoked on the success path (executeRowEvaluation), silently skipping failed rows. This meant consumers relying on onResult for logging/persistence never saw errors. Extract shared emitResult helper used by both success and error paths, which also eliminates callback logic duplication and reduces handleRowError cyclomatic complexity. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yltw27
requested review from
djslimbo,
horlaarsco and
matt-koevort
and removed request for
a team
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
matt-koevort
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onResultcallback was only called on the success path (executeRowEvaluation), so failed rows were silently dropped — consumers never saw errors via the callbackemitResult()helper used by both success and error paths, ensuringonResultfires for all rowshandleRowErrorcyclomatic complexity (code health 9.09 → 10.0)Test plan
🤖 Generated with Claude Code