PHP 8.4 compatibility

[ohorbatiuk]

When I use functions from and renderImage, I encounter the following errors:

1. Deprecated: Elphin\IcoFileLoader\IcoFileService::__construct(): Implicitly marking parameter $renderer as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/lordelph/icofileloader/src/IcoFileService.php on line 30

2. Deprecated: Elphin\IcoFileLoader\IcoFileService::__construct(): Implicitly marking parameter $parser as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/lordelph/icofileloader/src/IcoFileService.php on line 30

3. Deprecated: Elphin\IcoFileLoader\IcoFileService::extractIcon(): Implicitly marking parameter $opts as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/lordelph/icofileloader/src/IcoFileService.php on line 59

4. Deprecated: Elphin\IcoFileLoader\IcoFileService::renderImage(): Implicitly marking parameter $opts as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/lordelph/icofileloader/src/IcoFileService.php on line 88

5. Deprecated: Elphin\IcoFileLoader\GdRenderer::render(): Implicitly marking parameter $opts as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/lordelph/icofileloader/src/GdRenderer.php on line 12

6. Deprecated: Elphin\IcoFileLoader\RendererInterface::render(): Implicitly marking parameter $opts as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/lordelph/icofileloader/src/RendererInterface.php on line 18

[vojtech-dobes]

@lordelph Hi! Do you think this will be merged & released soon, or should we use a fork in mean time? Thanks for your time!

[konradmichalik]

Thank you for the pull request @lexhouk. I would also like to see the request merged soon.

---

Sorry, @lexhouk. 😆

[DimaSuharchuk]

@ohorbatiuk I'm not a contributor for the library, but everything looks fine to me :)

[ohorbatiuk]

@DimaSuharchuk I just saw you in the reviewer section, where it says that you are expected to review. But if you don't see the button to approve changes on the last tab, then we will wait for review from the repository owners.

[DimaSuharchuk]

@ohorbatiuk Unfortunately, I do not have the necessary access for this.

[DimaSuharchuk]

Everything looks fine