feat: runtime server URL config via ServerConfig#1
Open
lofimichael wants to merge 3 commits into
Open
Conversation
Single source of truth for HTTP API and WebSocket URLs. Resolution: env var (CITYSCAPE_API_URL) → Info.plist → Railway default. Derives WebSocket URL from HTTP URL via URLComponents parsing. 10 unit tests for URL resolution, scheme derivation, and path stripping.
APIClient and ChannelManager now read from ServerConfig.shared instead of compile-time #if DEBUG branching. Both HTTP and WebSocket URLs are derived from a single configurable source.
Use open --env (macOS 14+) to pass CITYSCAPE_API_URL to the app process. Document server configuration in README. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lofimichael
added a commit
that referenced
this pull request
Mar 20, 2026
* docs: product research and vision for WiFi-based social discovery Comprehensive product research covering technical feasibility (CoreWLAN, iMessage automation), competitive landscape (8 failed proximity apps), product design (user flows, trust/safety, cold start), and architecture. CEO review accepted 8 scope expansions including ambient spatial board, cross-venue awareness, office hours beacons, and venue intelligence. Eng review defined Phoenix contexts, DB schema, API contract, and 3-wave implementation plan. * chore: bump version and changelog (v0.1.0.0) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CITYSCAPE_API_URL) → Info.plist (CityscapeAPIURL) → hardcoded Railway defaulthttps→wss,http→ws, strips/apipath via URLComponents parsing. No more independent config in two places#if DEBUGcompile-time URL switching withServerConfig.sharedopen --env(macOS 14+) to passCITYSCAPE_API_URLto the app process. Fixes a bug where env vars from the shell weren't reaching the GUI app#if DEBUGstays for auth mode (dev auto-auth vs Sign in with Apple). Auth mode follows the build type, not the server URLTest plan
openenv var bug, fixed🤖 Generated with Claude Code