feat: payload data availability votes + rename ptcVotes (consensus-specs#4884, #4930)#8
Open
lodekeeper wants to merge 2 commits intounstablefrom
Open
feat: payload data availability votes + rename ptcVotes (consensus-specs#4884, #4930)#8lodekeeper wants to merge 2 commits intounstablefrom
lodekeeper wants to merge 2 commits intounstablefrom
Conversation
…ecs#4884, ChainSafe#4930) - Rename ptcVotes → payloadTimelinessVotes to match spec naming - Add payloadDataAvailabilityVotes BitArray map for blob availability tracking - Add DATA_AVAILABILITY_TIMELY_THRESHOLD constant (PTC_SIZE / 2) - Update notifyPtcMessages to accept 4 args (+ blobDataAvailable) - Add isPayloadDataAvailable() method to proto-array - Update shouldExtendPayload: condition 1 = isPayloadTimely AND isPayloadDataAvailable - Initialize both vote maps to all-True for anchor block per get_forkchoice_store spec
…le tests Fix 5 test call sites still passing 3 arguments to notifyPtcMessages after the 4-arg signature change (missing blobDataAvailable parameter). Add dedicated test suite for isPayloadDataAvailable(): - returns false for unknown block - returns false when no FULL variant exists - returns true when threshold met and payload available - returns false when below threshold - tracks data availability votes independently from timeliness votes 🤖 Generated with AI assistance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Implement payload data availability tracking (ethereum/consensus-specs#4884) and rename ptcVotes to match spec naming (ethereum/consensus-specs#4930).
Changes
Rename (consensus-specs#4930)
ptcVotes→payloadTimelinessVotesto match spec namingData availability votes (consensus-specs#4884)
payloadDataAvailabilityVotesBitArray map for blob availability trackingDATA_AVAILABILITY_TIMELY_THRESHOLDconstant (PTC_SIZE / 2)notifyPtcMessagesto accept 4 args (+ blobDataAvailable)isPayloadDataAvailable()method to proto-arrayshouldExtendPayload: condition 1 =isPayloadTimely AND isPayloadDataAvailableAnchor block initialization
get_forkchoice_storespecSplit from alpha.3 upgrade PR #6.