Skip to content

feat!(config, prepro): Change hostTaxonId from int to string#6487

Open
maverbiest wants to merge 4 commits into
mainfrom
hosttaxonid-int-to-string
Open

feat!(config, prepro): Change hostTaxonId from int to string#6487
maverbiest wants to merge 4 commits into
mainfrom
hosttaxonid-int-to-string

Conversation

@maverbiest
Copy link
Copy Markdown
Contributor

@maverbiest maverbiest commented May 21, 2026

BREAKING CHANGES

This PR changes the type of metadata field hostTaxonId from int to string.

(will only affect deployments that configure a hostTaxonId: int metadata field)

How to address

Update the type of the hostTaxonId metadata field to a string in your values.yaml:

metadata:
  - name: hostTaxonId
    type: string

and run the following SQL command against your database once you've rolled out:

UPDATE public.sequence_entries_preprocessed_data
SET processed_data = jsonb_set(
	processed_data,
	'{metadata, hostTaxonId}',
	to_jsonb(processed_data -> 'metadata' ->> 'hostTaxonId')
)
WHERE processed_data->'metadata' ? 'hostTaxonId';

Summary

We want to add a hierarchical filter on the hostTaxonId field, this was initially merged in #6302 and has since been reverted since it was a breaking change that we hadn't properly tested in a live deployment.

We have since tested this change on staging in combination with a SQL command to change the type of hostTaxonId to string in the DB. This worked smoothly. The current PR just changes the type of hostTaxonId in the config, preprocessing function, and ENA tests. The actual implementation of hierarchical filters will be reintroduced in a follow-up PR.

This keeps the PRs more focused and separates the concerns.

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by appropriate, automated tests.
  • Any manual testing that has been done is documented (i.e. what exactly was tested?)

🚀 Preview: https://hosttaxonid-int-to-string.loculus.org

@claude claude Bot added deposition related to ENA/INSDC deposition deployment Code changes targetting the deployment infrastructure preprocessing Issues related to the preprocessing component labels May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment Code changes targetting the deployment infrastructure deposition related to ENA/INSDC deposition preprocessing Issues related to the preprocessing component preview Triggers a deployment to argocd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants