feat!(config, prepro): Change hostTaxonId from int to string#6487
Open
maverbiest wants to merge 4 commits into
Open
feat!(config, prepro): Change hostTaxonId from int to string#6487maverbiest wants to merge 4 commits into
maverbiest wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
This PR changes the type of metadata field
hostTaxonIdfrom int to string.(will only affect deployments that configure a
hostTaxonId: intmetadata field)How to address
Update the type of the hostTaxonId metadata field to a string in your
values.yaml:and run the following SQL command against your database once you've rolled out:
Summary
We want to add a hierarchical filter on the hostTaxonId field, this was initially merged in #6302 and has since been reverted since it was a breaking change that we hadn't properly tested in a live deployment.
We have since tested this change on staging in combination with a SQL command to change the type of hostTaxonId to string in the DB. This worked smoothly. The current PR just changes the type of hostTaxonId in the config, preprocessing function, and ENA tests. The actual implementation of hierarchical filters will be reintroduced in a follow-up PR.
This keeps the PRs more focused and separates the concerns.
PR Checklist
🚀 Preview: https://hosttaxonid-int-to-string.loculus.org