Address original data download review comments#6448
Open
theosanderson-agent wants to merge 4 commits into
Open
Address original data download review comments#6448theosanderson-agent wants to merge 4 commits into
theosanderson-agent wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up for #5856 addressing several review comments on the original-data download feature.
Changes:
idcolumn and single-segment FASTA headerscountOriginalData/streamOriginalDatafinallyblock for the zip streaming responserequired = trueschema annotationI left the writer close/flush comments alone: these writers are wrapping an active
ZipOutputStreamentry, so closing the wrapped writer would close the whole zip stream before later entries are written.Checks
JAVA_HOME=/usr/lib/jvm/java-21-openjdk-amd64 ./gradlew test --tests org.loculus.backend.controller.submission.GetOriginalDataEndpointTestJAVA_HOME=/usr/lib/jvm/java-21-openjdk-amd64 ./gradlew ktlintChecknpm run check-types(passes with existingEditableSequences.spec.tsdeprecation hints)npx prettier --check src/components/SearchPage/DownloadDialog/DownloadOriginalDataButton.tsx src/services/backendClientSideApi.tsgit diff --checkNote: repo-wide
npm run check-formatcurrently fails on existing unrelated lint issues inEditableSequences.spec.ts,SearchForm.spec.tsx, andFileUploadComponent.tsx.🚀 Preview: Add
previewlabel to enable