Skip to content

fix(website): improve revocation banner placement and wording #6426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
theosanderson-agent wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(website): improve revocation banner placement and wording #6426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion website/src/components/SequenceDetailsPage/SequencesBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const SequencesBanner: FC<SequencesBannerProps> = ({ sequenceEntryHistory, acces
{ownHistoryEntry?.isRevocation && (
<div className='bg-red-100 border-l-4 border-red-500 text-red-700 p-3' role='alert'>
<p className='font-bold'>
This is a revocation version. It essentially contains no data, it's just a marker that all
This is a revocation version. It essentially contains no data: it is just a marker that all
previous versions have been revoked.
</p>
</div>
Expand Down
17 changes: 6 additions & 11 deletions website/src/pages/seq/[accessionVersion]/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,6 @@ const sequenceFlaggingConfig = getWebsiteConfig().sequenceFlagging;
title={sequenceDetailsTableData.isOk() ? accessionVersion : 'Sequence not found'}
implicitOrganism={sequenceDetailsTableData.isOk() ? sequenceDetailsTableData.value.organism : undefined}
>
{
sequenceDetailsTableData.isOk() &&
sequenceDetailsTableData.value.result.type === SequenceDetailsTableResultType.TABLE_DATA && (
<div slot='banner'>
<SequencesBanner
sequenceEntryHistory={sequenceDetailsTableData.value.result.sequenceEntryHistory}
accessionVersion={accessionVersion}
/>
</div>
)
}
{
sequenceDetailsTableData.match(
({ organism, result }) => {
Expand All @@ -72,6 +61,12 @@ const sequenceFlaggingConfig = getWebsiteConfig().sequenceFlagging;
showDownloadAndReport && getSegmentNames(getReferenceGenomes(organism)).length > 0
}
/>
{result.type === SequenceDetailsTableResultType.TABLE_DATA && (
<SequencesBanner
sequenceEntryHistory={result.sequenceEntryHistory}
accessionVersion={accessionVersion}
/>
)}
{result.type === SequenceDetailsTableResultType.TABLE_DATA &&
(result.isRevocation ? (
<RevocationEntryDataTable
Expand Down
Loading