feat(prepro): fix alignment ANY requirement - prepro should error if …#6413
feat(prepro): fix alignment ANY requirement - prepro should error if …#6413anna-parker wants to merge 2 commits into
Conversation
…the segment cant be assigned and warn if can be assigned but not aligned
claude
Bot
added
preprocessing
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 185fece775
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ) | ||
| ) | ||
|
|
||
| return sequence_assignment |
There was a problem hiding this comment.
Returning immediately here drops the previous safeguard that emitted an error when sequence_assignment.unalignedNucleotideSequences stayed empty without any duplicate/unaligned diagnostics. In multi-segment mode, an entry with no uploaded nucleotide sequences now reaches later processing with no classification error, which can make a no-sequence submission look valid instead of being rejected with an explicit alignment/classification message.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
If classification fails then nothing will align and the function alignment_errors_warnings will add an error so this should be fine
2 participants
…the segment cant be assigned and warn if can be assigned but not aligned
resolves #
Screenshot
PR Checklist
🚀 Preview: Add
previewlabel to enable