Make the ignore clock skew parameter follow the generic pattern#410
Open
svanharmelen wants to merge 1 commit intolocka99:masterfrom
Open
Make the ignore clock skew parameter follow the generic pattern#410svanharmelen wants to merge 1 commit intolocka99:masterfrom
svanharmelen wants to merge 1 commit intolocka99:masterfrom
Conversation
All other parameters take a value, while this one did not. Especially when we (maybe) want to set the default to `true` one day, this would become an issue (next to it not being consistent now). Normally such a change would not be worth causing a backwards incompatibility issue, but since the rewritten client isn't released yet it feels like this is the best possible time to correct this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All other parameters take a value, while this one did not. Especially when we (maybe) want to set the default to
trueone day, this would become an issue (next to it not being consistent now).Normally such a change would not be worth causing a backwards incompatibility issue, but since the rewritten client isn't released yet it feels like this is the best possible time to correct this.