fix(faqwikius): The website moved all content to /novel.#2212
Merged
Conversation
Collaborator
|
add this line to parseNovel somewhere |
Contributor
Author
|
Done. |
Collaborator
oops, i meant L#60+ |
…o parseNovel method
…seNovel to parseNovelDetails for clarity
K1ngfish3r
reviewed
May 21, 2026
Comment on lines
+57
to
+61
| async parseNovel(path: string): Promise<Plugin.SourceNovel> { | ||
| // Fetches and parses a single novel's full details page (metadata, chapters, status). | ||
| // "Details" distinguishes it from the list parser above. | ||
| async parseNovelDetails(path: string): Promise<Plugin.SourceNovel> { |
Collaborator
There was a problem hiding this comment.
name of this cant be changed, revert
K1ngfish3r
reviewed
May 21, 2026
Comment on lines
+13
to
+15
| parseNovels(loadedCheerio: CheerioAPI, searchTerm?: string) { | ||
| // Parses a list of NovelItem objects from already-loaded Cheerio HTML. | ||
| // "List" clarifies it returns NovelItem[] (used by popularNovels and searchNovels). | ||
| parseNovelList(loadedCheerio: CheerioAPI, searchTerm?: string) { |
Contributor
Author
There was a problem hiding this comment.
I was going to sleep after this, my bad.
nofzo
pushed a commit
to nofzo/lnreader-plugins
that referenced
this pull request
May 22, 2026
* fix(faqwikius): update site URL to include '/novel' for correct navigation * chore: bumped version of faqwiki * fix(faqwikius): remove script tags from parsed HTML to clean up novel data * fix(faqwikius): move the remove script tags from parseNovels method to parseNovel method * chore(faqwikius): rename parseNovels method to parseNovelList and parseNovel to parseNovelDetails for clarity * fix(faqwikius): reversion of previous commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[ x ] Update version code if an existing plugin was modified
[ x ] Test changes in Plugin Playground or the app
[ x ] Reference related issues in the PR body (e.g. Closes #xyz)
Changed the
siteproperty in theFaqWikiUsplugin to point to the new URL (https://faqwiki.us/novel) and updated theversionto3.0.1to match the latest site changes.