fix(novelbuddy): fix watermark regex for obfuscated watermarks#2196
Closed
7ui77 wants to merge 5 commits into
Closed
fix(novelbuddy): fix watermark regex for obfuscated watermarks#21967ui77 wants to merge 5 commits into
7ui77 wants to merge 5 commits into
Conversation
Removed an accidental double pipe '||' in the 'l' group of fwnRegex which was causing partial matches and incomplete watermark removal.
…s, bump version to 2.1.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
fwnRegexused by the NovelBuddy plugin to remove obfuscated watermarks.Issue
The
lcharacter group in the regex contained an accidental double pipe||, which created an empty match option. This caused the regex to stop matching prematurely (matchingfreewebnoveinstead offreewebnovel.com), leading to incomplete watermark removal.Fix
Removed the extra pipe character in the
lgroup.Verification
Verified against Chapter 120 of "Dual Cultivation" which contains the watermark
ƒ𝚛𝐞𝚎𝑤𝘦𝚋𝓷o𝚟e𝘭.c𝐨𝙢. The fix allows the regex to match and remove the entire string correctly.