feat(en): add Wuxia Dreams plugin#2162
Closed
7ui77 wants to merge 3 commits into
Closed
Conversation
K1ngfish3r
requested changes
May 2, 2026
Collaborator
There was a problem hiding this comment.
- dont use homepage for popularNovels()
- add more filters (eg: ranking)
- since you are not using homepage, can move cheerio code to helper
- some novels dont have genres, use tags for genres instead
- since only two status types, can ternary them //optional
- use POST request for chapter fetch instead
- no scripts or style tags inside chapterText
Comment on lines
+153
to
+157
| if (p > 1) { | ||
| const pageUrl = `${url}?page=${p}`; | ||
| const pageBody = await fetchApi(pageUrl).then(r => r.text()); | ||
| pageCheerio = parseHTML(pageBody); | ||
| } |
Collaborator
There was a problem hiding this comment.
- use POST request for chapter fetch instead
7ui77
force-pushed
the
feat/wuxiadreams-upstream
branch
2 times, most recently
from
772d251 to
4a6895b
Compare
7ui77
force-pushed
the
feat/wuxiadreams-upstream
branch
from
4a6895b to
77a3a63
Compare
7ui77
force-pushed
the
feat/wuxiadreams-upstream
branch
from
41888bd to
5b7d4e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Note:
The plugin icon has been added to
public/static/src/en/wuxiadreams/icon.png.Close #2159