Fix JMD display precision handling in wallet transaction mapping#368
Open
temp4allOG wants to merge 1 commit into
Open
Fix JMD display precision handling in wallet transaction mapping#368temp4allOG wants to merge 1 commit into
temp4allOG wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backend-side fixes for JMD precision and display consistency from issue #282.
Included changes
src/app/wallets/get-transactions-for-wallet.tsdisplayCurrency: "USD"; now uses transaction display currency when availableMath.floor(...)withMath.round(...)for exchange-rate base conversion to avoid systematic downward truncationsettlementDisplayAmount/settlementDisplayFeevalues from upstream transaction payload when providedsrc/graphql/shared/types/object/btc-wallet.tsNotes
lnflash/flash.lnflash/flash-mobileand should be handled in a paired PR.Validation
BTC fallback address:
1BL4eV82zZ64Dp4cj3s9EgJ3ae8xPx5ZuJ