Skip to content

fix: currencies without decimal#209

Merged
talvasconcelos merged 2 commits intomainfrom
fix/no_decimal_currency
Mar 19, 2026
Merged

fix: currencies without decimal#209
talvasconcelos merged 2 commits intomainfrom
fix/no_decimal_currency

Conversation

@talvasconcelos
Copy link
Collaborator

@talvasconcelos talvasconcelos commented Mar 11, 2026

There are currencies that have no decimal, or at least different decimal than the default 2 LNbits is using.

Fix adds a couple helper methods (these will later be added as core utils) that get the selected currency's minimum fraction digits.

Initial testing looks good! Needs a bit more testing (ATM, use with Inventory)

Fixes #206

@arcbtc
Copy link
Member

arcbtc commented Mar 14, 2026

Doesnt work for me.

Also on the original issue, CLP is not supposed to have decimal places

image

@talvasconcelos talvasconcelos force-pushed the fix/no_decimal_currency branch from 9a987e5 to 876d3e4 Compare March 16, 2026 09:49
do not mutate `total` on `submitForm`
@talvasconcelos talvasconcelos merged commit dc92daf into main Mar 19, 2026
15 checks passed
@talvasconcelos talvasconcelos deleted the fix/no_decimal_currency branch March 19, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] for currencies that have no decimal part, data enrty is borked.

2 participants