Patch ninja exe path to whatever is in test runner env, and foolproof cmake timestamps#1149
Open
Patch ninja exe path to whatever is in test runner env, and foolproof cmake timestamps#1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are still encountering errors when configuring cmake with ninja, as ninja cannot be found:
https://github.com/llvm/offload-test-suite/actions/runs/25338698984/job/74291993540#step:13:155
Though the path is correct on the build machine's environment, it no longer holds in the test machine's (a different machine's) environment.
We need to rewrite the path to ninja on the test machine side so that ninja can be found, so we can guarantee that cmake can configure correctly.
Additionally, we can force the timestamps to be ~24 hours in the future, to completely disallow the possibility of cmake thinking it should regenerate outputs.
Fixes #1150