[WebAssembly] Remove __c_longjmp from compiler-rt#185798
Merged
Conversation
This is similar to llvm#185770 where it removes an exception-handling-related symbol from `compiler-rt` in favor of having definitions elsewhere. The compiler-rt library is linked into all shared objects, for example, which can result in duplicate definitions of a symbol where this tag wants to have one unique definition. The intention behind this commit is to defer the definition of this symbol to downstream libraries, such as the definition of `longjmp` itself. An example of this is WebAssembly/wasi-libc#772 where the responsibility of defining this symbol now lies with wasi-libc.
Contributor
Author
|
r? @sbc100 |
sbc100
approved these changes
Mar 11, 2026
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/24/builds/18383 Here is the relevant piece of the build log for the reference |
Member
|
@sbc100 When we merge this downstream in emscripten, where do you plan to add |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/38/builds/8167 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/14140 Here is the relevant piece of the build log for the reference |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to #185770 where it removes an
exception-handling-related symbol from
compiler-rtin favor of having definitions elsewhere. The compiler-rt library is linked into all shared objects, for example, which can result in duplicate definitions of a symbol where this tag wants to have one unique definition. The intention behind this commit is to defer the definition of this symbol to downstream libraries, such as the definition oflongjmpitself. An example of this is WebAssembly/wasi-libc#772 where the responsibility of defining this symbol now lies with wasi-libc.