Fixed XML compatibility of expectation set/values#24
Open
WardLT wants to merge 2 commits intollnl:masterfrom
Open
Fixed XML compatibility of expectation set/values#24WardLT wants to merge 2 commits intollnl:masterfrom
WardLT wants to merge 2 commits intollnl:masterfrom
Conversation
Author
|
I have checked that this compiles (sorry for not doing so earlier), but am unable to verify that the changes make the output valid XML because I do not have an appropriate input file to test this part of QBall. Do you have something that I could use for that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the XML compatibility, as discussed in #23
Note: I have not verified whether this compiles.