Merged
Conversation
cyrush
approved these changes
Mar 30, 2026
Member
cyrush
left a comment
cyrush
left a comment
There was a problem hiding this comment.
This looks good, code is easier to understand and comments are great.
Thanks for this!
| index_t next_slot_index = slot_index; | ||
| for(const auto& zone_mix_mat : elem_mat_map) | ||
| // num_elems by num_materials mf vals vectors | ||
| std::vector<std::vector<std::vector<float64>>> mf_vals(num_elems, |
Member
There was a problem hiding this comment.
triple std vector scares me a little bit for the future, but we will figure it out.
Member
Author
There was a problem hiding this comment.
species make things complicated :)
JustinPrivitera
deleted the
task/JustinPrivitera/01_27_26/to_silo_modern_rewrite
branch
Member
|
Awesome work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rewrite to_silo
make it much faster
remove support for strangely formatted matsets
add support for all specset layouts
to_siloperformance #1362to_silosupports a non-idiomatic volume fraction presentation case. Should we remove it? #1470Resolves #1362
Resolves #1470
Resolves #1496