feat(install): port install to Node — drops Perl requirement, succeeds on pure Windows#4
Open
97wow wants to merge 1 commit into
Open
feat(install): port install to Node — drops Perl requirement, succeeds on pure Windows#497wow wants to merge 1 commit into
97wow wants to merge 1 commit into
Conversation
…s on pure Windows bin/cli.js now does the five install phases (copy / backup / merge / verify / dry-run) directly in Node, replacing the spawnSync to bash install.sh that required Perl + JSON::PP. install.sh is kept as a documented legacy POSIX-with-perl path. Behavior preserved 1:1: - Substring match on next/scripts/ingest.sh for idempotent re-install - Backup settings.json with .bak-YYYYMMDD-HHMMSS stamp - Canonical sorted-key JSON output - UTF-8 round-trip (Chinese / emoji hook labels preserved) - Same 8 dry-run assertions (including 0.2.9 false-positive guards) Pure-Win behavior: install completes, hook merged, dry-run auto-skipped with explicit guidance to install Git for Windows for the bash runtime. Reverse-proved 4/4: - WSL POSIX e2e: 8/8 dry-run cases pass - Re-install idempotent (hook count stays 1) - Existing hooks merged (OtherEvent preserved, ours appended) - UTF-8 (Chinese + emoji round-trip) - No-bash environment (install succeeds, runtime warning shown)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npx claude-next installno longer needs Perl. The five install phases (copy / backup / merge / verify / dry-run) are now native Node code inbin/cli.js;install.shis kept as a documented legacy POSIX-with-perl path. Closes the install-time half of the README roadmap item PowerShell fallback for pure-Windows environments.Behavior preserved 1:1
next/scripts/ingest.shfor idempotent re-install (no duplicate hook on repeatnpx claude-next install)~/.claude/settings.jsonto.bak-YYYYMMDD-HHMMSS(matchesinstall.sh's timestamp format)->canonical)What changes for the user
npx claude-next installstill works. Directbash install.shstill works.Reverse-prove (4/4 PASS)
Per claude-next dogfooding rule: every claim reverse-proved against current src before code change.
OtherEvent+ a Chinese-echoUserPromptSubmitentry中文+ 🎉 emojiPATH=/tmp/empty-bin /usr/bin/node bin/cli.js installTest plan
npx claude-next@<this-branch> installcompletes with the warning and produces a valid~/.claude/settings.jsonUserPromptSubmitnpx claude-next installis bit-identical in behavior to v0.2.10🤖 Generated with Claude Code