LK_LOG_* using spdlog, supporting users specifying their own logging …#68
Open
stephen-derosa wants to merge 3 commits intolivekit:mainfrom
Open
LK_LOG_* using spdlog, supporting users specifying their own logging …#68stephen-derosa wants to merge 3 commits intolivekit:mainfrom
stephen-derosa wants to merge 3 commits intolivekit:mainfrom
Conversation
…systems (i.e. for ros2 integration)
| namespace livekit { | ||
|
|
||
| void initializeLogger(); | ||
| void shutdownLogger(); |
Collaborator
There was a problem hiding this comment.
should we just embed the initializeLogger into the initialize() function ? and not expose initializeLogger and shutdownLogger() ?
I think it is very important to keep the public APIs small.
| void initializeLogger(); | ||
| void shutdownLogger(); | ||
|
|
||
| bool initialize(LogLevel level) { |
Collaborator
There was a problem hiding this comment.
why do we need to overload this initialize() function ?
how about
bool initialize(LogSink log_sink, LogLevel level) ?
Collaborator
|
some questions to the public APIs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
LK_LOG system for using spdlog instead of std::cerr/cout or printf.
Examples
spdlog(i.e. in the case applications already have their own logging systems)Testing
Logger integration tests