Skip to content

Fix undefined behavior. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ingomueller-net wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix undefined behavior. #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ static const int kPageSize = 4096;
class AIORequest {
public:
int* buffer_;
struct iocb iocb_;

virtual void Complete(int res) = 0;

Expand Down Expand Up @@ -237,9 +238,9 @@ class AIOAdder : public Adder {

void SubmitWrite() {
LOG(INFO) << "Submitting a write to " << counter_;
struct iocb iocb;
struct iocb* iocbs = &iocb;
AIORequest *req = new AIOWriteRequest(counter_);
struct iocb& iocb = req->iocb_;
struct iocb* iocbs = &iocb;
io_prep_pwrite(&iocb, fd_, req->buffer_, kPageSize, counter_ * kPageSize);
iocb.data = req;
int res = io_submit(ioctx_, 1, &iocbs);
Expand All @@ -257,9 +258,9 @@ class AIOAdder : public Adder {

void SubmitRead() {
LOG(INFO) << "Submitting a read from " << counter_;
struct iocb iocb;
struct iocb* iocbs = &iocb;
AIORequest *req = new AIOReadRequest(this);
struct iocb& iocb = req->iocb_;
struct iocb* iocbs = &iocb;
io_prep_pread(&iocb, fd_, req->buffer_, kPageSize, counter_ * kPageSize);
iocb.data = req;
int res = io_submit(ioctx_, 1, &iocbs);
Expand Down