[updates] specify python version

[partizipation]

If a developer is using pyenv, a new .python-version file will force them onto the latest supported version.

If not, they can now see in the README the supported version. Additionally, if they are on a non-supported version, when running make install an warning will be printed to the console.

@m4ra you mentioned make clean doesn't remove the venv directory when using pyenv, but it seems to be. Maybe this is no longer happening. If there are other issues with pyenv we could smooth out, maybe now would be a good time though, so let me know.

edit: also added a note in README that macOS users will need to install libmagic

[hom3mad3]

@arc64 this about the python version, btw

[hom3mad3]

Nice!

[m4ra]

I would argue for writing a project.toml in the adhocracy-4 library and define the python version there, instead of constraining how developers should setup their virtualenv. Having a project.toml is also the standard fashion of publishing packages.

[m4ra]

Personally I use pyenv for versions, and pyenv for virtualenv, so this file points to the name of my pyenv's virtualenv, e.g named root which is located in .pyenv/versions/(venv) and that's why cannot be deleted with the make clean command. Hence, I don't think the solution here is inclusive enough approach.

[partizipation]

Could you say a little more? The make install command uses python3 -m venv $(VIRTUAL_ENV); so our clean script deletes this venv. What additional behavior would you expect?

[m4ra]

I create virtuanvs with pyenv virtualenv <name-of-venv> for all my projects, which places venvs in the home directory of /home/<user>/.pyenv/versions/<name-of-venv>

[hom3mad3]

I would argue for writing a project.toml in the adhocracy-4 library and define the python version there, instead of constraining how developers should setup their virtualenv. Having a project.toml is also the standard fashion of publishing packages.

you bring some good points and i haven't really tried it myself. .python-version defaults my version in case i forget, so that is already quite helpful.

[hom3mad3]

with a docker build this should also be fixed tbh 🙈