Add feature product data fetch with queue#52
Open
AdamLipscore wants to merge 1 commit intomain-2.xfrom
Open
Conversation
AdamLipscore
force-pushed
the
lipscore-product-api-v2
branch
from
f707785 to
4a6ac0e
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const XML_PATH_LIPSCORE_API_KEY = 'lipscore_general/api_key/api_key'; | ||
| const XML_PATH_LIPSCORE_API_SECRET = 'lipscore_general/api_key/secret'; | ||
| const XML_PATH_WEBHOOK_ENABLED = 'lipscore_general/webhook/enabled'; | ||
| const XML_PATH_WEBHOOK_SECRET = 'lipscore_general/webhook/hmac_secret'; |
There was a problem hiding this comment.
🚫 [Bearer] <php_lang_hardcoded_secret> reported by reviewdog 🐶
Usage of hard-coded secret
Description
Storing secret values directly in the source code exposes them to unauthorized access and compromises security. This practice makes your application vulnerable to attacks.
Remediations
- Do not hard-code secrets in your application code. Hard-coding makes sensitive information easily accessible to anyone who can view the code.
- Do use environment variables to manage secrets securely. This method keeps sensitive information out of your codebase and makes it more difficult for unauthorized users to access.
- Do retrieve secrets from a secure location at runtime. This approach minimizes the risk of exposing sensitive information and enhances the security of your application.
$secret = getenv('SECRET_KEY');
- Do consider implementing a key-management system to securely handle secrets and other sensitive information. This approach provides enhanced security measures for managing and accessing credentials.
References
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.