Skip to content

chore: improve copy_option and PR overview advice #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwsilk merged 2 commits into from
Apr 8, 2026
+3 −1
Merged

chore: improve copy_option and PR overview advice #677

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8850a74
chore: improve copy_option and PR overview advice
dwsilk Apr 8, 2026
5301406
chore: apply suggestions from copilot
dwsilk Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

This repository contains STAC Collection metadata and data publishing configuration files for New Zealand elevation datasets.

There is no need to add a Pull Request overview beyond confirming how many new or changed files were reviewed. Inline comments and/or suggestions where discrepancies are identified are the priority.

## publish-odr-parameters

When elevation data is published to the Registry of Open Data on AWS, a configuration file is created here containing some parameters for the publishing process. When reviewing changes to `publish-odr-parameters` files, check the following rules.
Expand All @@ -12,7 +14,7 @@ When elevation data is published to the Registry of Open Data on AWS, a configur
- There should be a maximum of one new `publish-odr-parameters` file added per Pull Request. If there is more than one, older parameter files should be deleted. There can also be zero parameter files, if only `collection.json` metadata is being updated.
- The `target` is `"s3://nz-elevation/{region}/{survey}/{product}/{projection}/"` which should align to the dataset metadata stored in this repository at `stac/{region}/{survey}/{product}/{projection}/collection.json`.
- The `region` in the parameter file must match the region directory name in the repository path `stac/{region}/`.
- The `copy_option` should be `--force-no-clobber` if there are any `file:checksum` values being modified in the `collection.json` file within the same Pull Request. If the Pull Request only contains links to new items with new `file:checksum` values, then the `copy_option` should be `--no-clobber`.
- Check whether any `file:checksum` values are being changed within a `collection.json` file in this Pull Request. The `copy_option` in the parameter file should be `--force-no-clobber` if any `file:checksum` values have changed. If the `collection.json` is a newly added file, if it only contains links to new items with new `file:checksum` values, or if `collection.json` changes do not modify any `file:checksum` values, then the `copy_option` should be `--no-clobber`.

## stac

Expand Down