Skip to content

Allow update, when powersupply is offline and battery >= 75% #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Codekloeppler wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −1
Open

Allow update, when powersupply is offline and battery >= 75% #1021

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7b1a65
Update power supply check to include battery capacity
Codekloeppler Feb 11, 2026
7baac9e
Merge branch 'linuxmint:master' into master
Codekloeppler Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion usr/lib/linuxmint/mintUpdate/automatic_upgrades.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,14 @@
power_supply_file = open(power_connectfile)
powersupply = power_supply_file.read()[0]=='1'
power_supply_file.close()
if !powersupply:
Copy link
Contributor

@randomnoise randomnoise Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a valid python statement:

  File "/tmp/tmp.NzVPhaFruT/automatic_upgrades.py", line 23
    if !powersupply:
       ^
SyntaxError: invalid syntax

battery_capacity_file = open('/sys/class/power-supply/BAT0/capacity')
Copy link
Contributor

@randomnoise randomnoise Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on Linux kernel ABI documentation for power:

Suggested change
battery_capacity_file = open('/sys/class/power-supply/BAT0/capacity')
battery_capacity_file = open('/sys/class/power_supply/BAT0/capacity')

ABI for power is not stable, BAT0 may differ; so your code should consider that.

battery_capacity = int(battery_capacity_file.read())
battery_capacity_file.close()
except:
powersupply = True
log.write(power_connectfile+" not found. Ignore power supply check.")
if powersupply:
if powersupply or battery_capacity >= 75:
try:
# Put shutdown and reboot blocker into place
os.symlink(pkla_source, pkla_target)
Expand Down