Conversation
|
Please add this commit so it compiles on newer gcc |
|
Closes: #129 |
|
Although this PR compiles against mozjs140, the desktop itself doesn't load properly: black screen for a long time and then only right click context menu is available. This is typical when there's something odd happening with cinnamon + cjs + mozjs. I built the whole Cinnamon desktop environment from scratch today, using the latest versions of everything (including cinnamon 6.6.7). BTW, it's VERY confusing that you guys made available a version of the cinnamon project with a tag name containing 'cjs' keyword. And it looks for a version of cjs ( |
|
A while back, trying to support multiple versions of mozjs on different distros, we thought it would be less confusing to tie our cjs versions to the mozjs release instead of the Cinnamon release structure. Mint 21 still relies on an older version, but Mint 22 uses cjs 115 and LMDE7 use cjs 128. For a long time, Cinnamon remained compatible with cjs, regardless of version (which is why we never got around to updating that cjs version requirement in Cinnamon Up until this version, that is - because of the new gobject-introspection changes, there are fixes required in Cinnamon for it to remain universally compatible. Did you build off that PR in Cinnamon when trying this out? The 139.9 version is just for testing as a PR to distinguish it from the previous version. It will be 140 when merged...
These packages were generated off that pull request, there's nothing 'official' about it - they get auto-tagged with the branch name. I don't see the problem. If you build the Cinnamon PR that goes with this one and Cinnamon still crashes, did you happen to get a log or anything? The upstream gjs and associated glib/introspection code is still being actively worked on for this version, it's possible some new backports are needed here (which is why this hasn't been merged yet). |
Now I see. Indeed, building cinnamon with the PR you mentioned fixes the issue. Thanks for the explanation :) |
TODO: