ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]

[richm]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use newer tox-lsr and Ansible versions for Fedora 43 container and qemu tests, and optimize container test runs.

CI:

• Bump tox-lsr used in GitHub Actions workflows from 3.16.0 to 3.17.0.
• Switch Fedora 43 qemu and container test scenarios to use Ansible Core 2.20 instead of 2.19.
• Adjust container test job environment to run full setup on the first test and skip certain steps on subsequent runs for faster execution.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.0 and Ansible Core 2.20 on Fedora 43, and optimizes container test execution by adjusting environment variables to control requirements and callback plugins between test runs.

Flow diagram for container and qemu test execution with tox-lsr 3.17.0

flowchart TD
  A[Workflow_triggered] --> B[Checkout_repository]
  B --> C[Install_tox_lsr_3_17_0_via_pip]
  C --> D[Initialize_tox_environment]
  D --> E[Set_env_DISABLE_REQUIREMENTS_for_first_run]
  E --> F[Run_container_tests_without_extra_requirements]
  F --> G[Adjust_env_for_callback_plugins]
  G --> H[Run_container_tests_with_callback_plugins_enabled]
  H --> I[Run_qemu_kvm_integration_tests_with_ansible_core_2_20]
  I --> J[Collect_and_improve_test_output]
  J --> K[Publish_CI_results]

Loading

File-Level Changes

Change	Details	Files
Bump tox-lsr version used across GitHub Actions workflows to 3.17.0.	Update qemu integration workflow to install tox-lsr 3.17.0 via pip Update ansible-lint workflow to install tox-lsr 3.17.0 via pip Update ansible-managed-var-comment workflow to install tox-lsr 3.17.0 via pip Update ansible-test workflow to install tox-lsr 3.17.0 via pip	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Use Ansible Core 2.20 for Fedora 43-based qemu and container test scenarios.	Change Fedora 43 qemu scenario env from qemu-ansible-core-2-19 to qemu-ansible-core-2-20 Change Fedora 43 container scenario env from container-ansible-core-2-19 to container-ansible-core-2-20 Change Fedora 43 bootc container scenario env from container-ansible-core-2-19 to container-ansible-core-2-20	.github/workflows/qemu-kvm-integration-tests.yml
Adjust container test loop to leverage tox-lsr’s new behavior by toggling requirements and callback plugin setup between iterations.	Remove LSR_CONTAINER_PROFILE and LSR_CONTAINER_PRETTY overrides from container test step Initialize SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS as false before the first test run Set SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to true after each iteration to speed up subsequent runs	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The tox-lsr version (3.17.0) is hard-coded in multiple workflows; consider centralizing this (e.g., via a reusable workflow or a shared action) to avoid future version drift between CI jobs.
• In the container test loop, the SKIP_REQUIREMENTS / SKIP_CALLBACK_PLUGINS toggling relies on side effects between iterations; setting these explicitly at the top of each iteration based on whether it’s the first run would make the intent clearer and less error-prone.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The tox-lsr version (3.17.0) is hard-coded in multiple workflows; consider centralizing this (e.g., via a reusable workflow or a shared action) to avoid future version drift between CI jobs.
- In the container test loop, the SKIP_REQUIREMENTS / SKIP_CALLBACK_PLUGINS toggling relies on side effects between iterations; setting these explicitly at the top of each iteration based on whether it’s the first run would make the intent clearer and less error-prone.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}