ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox-lsr dependency and align qemu/container tox environment names with the new naming convention.

CI:

• Bump tox-lsr version from 3.15.0 to 3.16.0 across GitHub workflows.
• Rename qemu and container ansible-core tox environments in CI matrices from major.minor to major-minor format to avoid tox 4 python version parsing issues.

Documentation:

• Adjust contributing guide example to use the new qemu tox environment name format.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox/qemu integration to work with tox 4.49 by renaming qemu/container ansible-core testenv names from major.minor to major-minor and bumps tox-lsr to 3.16.0 across workflows, plus adjusts contributor docs to match new env naming.

Sequence diagram for GitHub Actions running qemu-ansible-core-X-Y tox env

sequenceDiagram
  actor Developer
  participant GitHub_Actions
  participant Workflow_ansible_test
  participant Step_install_tox_lsr
  participant Tox
  participant Tox_lsr
  participant Qemu_testenv as qemu_ansible_core_2_20
  participant Qemu_VM

  Developer->>GitHub_Actions: Push commit or open PR
  GitHub_Actions->>Workflow_ansible_test: Start workflow
  Workflow_ansible_test->>Step_install_tox_lsr: Run install step
  Step_install_tox_lsr->>Step_install_tox_lsr: pip install tox-lsr 3.16.0
  Workflow_ansible_test->>Tox: tox -e qemu-ansible-core-2-20
  Tox->>Tox_lsr: Load qemu env configuration
  Tox_lsr-->>Tox: Provide env qemu-ansible-core-2-20
  Tox->>Qemu_testenv: Create and run testenv
  Qemu_testenv->>Qemu_VM: Start qemu VM and run tests
  Qemu_VM-->>Qemu_testenv: Test results
  Qemu_testenv-->>Tox: Return status
  Tox-->>Workflow_ansible_test: Exit code and logs
  Workflow_ansible_test-->>GitHub_Actions: Job status
  GitHub_Actions-->>Developer: CI status on PR

Loading

File-Level Changes

Change	Details	Files
Align qemu and container CI matrix environment names with tox 4.49-compatible testenv names.	Rename qemu ansible-core testenv identifiers from dotted version style to dashed version style in the GitHub Actions qemu-kvm integration matrix. Ensure all qemu scenarios (centos, fedora, leap) and container scenarios (including bootc variants) use the new dashed env naming consistently, including commented-out entries.	.github/workflows/qemu-kvm-integration-tests.yml
Update tox-lsr dependency version in CI workflows to 3.16.0.	Bump tox-lsr version from 3.15.0 to 3.16.0 in qemu-kvm integration workflow. Bump tox-lsr version from 3.15.0 to 3.16.0 in ansible-lint, ansible-managed-var-comment, and ansible-test workflows so all CI jobs use the same newer tox-lsr release.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Sync contributor documentation with the new qemu tox environment naming scheme.	Change the example tox invocation in contributing documentation to use the dashed qemu-ansible-core-X-Y env name instead of the dotted X.Y form, and refresh the example version to 2-20 to reflect current supported ansible-core versions.	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The ansible-qemu example in contributing.md now references qemu-ansible-core-2-20, but the CI matrix only defines 2-16 to 2-19; consider aligning the example with an existing environment or explicitly documenting the difference.
• The tox-lsr version string 3.16.0 is duplicated across several workflows; consider centralizing this (e.g., via a workflow env var or reusable workflow) to make future version bumps less error-prone.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The ansible-qemu example in contributing.md now references `qemu-ansible-core-2-20`, but the CI matrix only defines `2-16` to `2-19`; consider aligning the example with an existing environment or explicitly documenting the difference.
- The tox-lsr version string `3.16.0` is duplicated across several workflows; consider centralizing this (e.g., via a workflow env var or reusable workflow) to make future version bumps less error-prone.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}