Skip to content

ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]#229

Merged
richm merged 1 commit intomainfrom
ci-container-improvements
Mar 11, 2026
Merged

ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]#229
richm merged 1 commit intomainfrom
ci-container-improvements

Conversation

@richm
Copy link
Contributor

@richm richm commented Mar 11, 2026

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43-based qemu and container tests, while optimizing container test runs via new environment controls.

CI:

  • Bump tox-lsr version from 3.16.0 to 3.17.0 across GitHub Actions workflows.
  • Switch Fedora 43 qemu and container test matrices to use Ansible core 2.20.
  • Adjust container test job environment to leverage tox-lsr skip flags for faster subsequent test runs.

…r fedora 43 [citest_skip]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from Jakuje as a code owner March 11, 2026 00:19
@richm richm self-assigned this Mar 11, 2026
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 11, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates GitHub Actions workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 test scenarios, and adjusts container test environment flags to leverage new tox-lsr behavior for faster, clearer runs.

Sequence diagram for CI_pipeline_with_tox_lsr_3_17_0_and_ansible_2_20

sequenceDiagram
  actor Dev as Developer
  participant GH as GitHub
  participant WF as GitHub_Workflow
  participant R as Runner
  participant P as Python_env
  participant TL as tox_lsr_3_17_0
  participant T as tox
  participant C as Container_or_QEMU_env
  participant A as Ansible_2_20

  Dev->>GH: Push_commit_or_open_PR
  GH->>WF: Trigger_ansible_CI_workflows
  WF->>R: Start_job_on_runner
  R->>R: Checkout_repository
  R->>P: Setup_Python_environment
  P->>P: pip_install_tox_lsr_3_17_0
  P->>TL: Initialize_tox_lsr
  TL->>T: Invoke_tox_with_new_flags
  T->>C: Start_container_or_qemu_tests
  C->>A: Run_playbooks_with_Ansible_2_20
  A-->>C: Test_results
  C-->>T: Aggregated_results_with_improved_output
  T-->>WF: Job_status
  WF-->>GH: Report_check_status
  GH-->>Dev: CI_status_on_PR
Loading

File-Level Changes

Change Details Files
Bump tox-lsr from 3.16.0 to 3.17.0 across CI workflows.
  • Update pip install command in qemu-kvm integration workflow to use tox-lsr 3.17.0.
  • Update pip install command in ansible-lint workflow to use tox-lsr 3.17.0.
  • Update pip install command in ansible-managed-var-comment workflow to use tox-lsr 3.17.0.
  • Update pip install command in ansible-test workflow to use tox-lsr 3.17.0.
.github/workflows/qemu-kvm-integration-tests.yml
.github/workflows/ansible-lint.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/ansible-test.yml
Switch Fedora 43 qemu/container scenarios to Ansible Core 2.20 in integration tests.
  • Change qemu Fedora 43 image env from qemu-ansible-core-2-19 to qemu-ansible-core-2-20.
  • Change container Fedora 43 image env from container-ansible-core-2-19 to container-ansible-core-2-20.
  • Change container Fedora 43 bootc image env from container-ansible-core-2-19 to container-ansible-core-2-20.
.github/workflows/qemu-kvm-integration-tests.yml
Adjust container test loop env flags to align with new tox-lsr container behavior and speed up subsequent runs.
  • Remove LSR_CONTAINER_PROFILE and LSR_CONTAINER_PRETTY debug-related overrides.
  • Introduce SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS environment variables, disabling skipping for the first test run.
  • Enable SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS after the first test iteration to skip setup on subsequent runs.
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 0e5cc50 into main Mar 11, 2026
30 checks passed
@richm richm deleted the ci-container-improvements branch March 11, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant