Skip to content

ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]#174

Open
richm wants to merge 1 commit intomainfrom
ci-container-improvements
Open

ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]#174
richm wants to merge 1 commit intomainfrom
ci-container-improvements

Conversation

@richm
Copy link
Contributor

@richm richm commented Mar 11, 2026

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use newer tox-lsr and Ansible versions and optimize container test execution for Fedora 43.

CI:

  • Bump tox-lsr version from 3.16.0 to 3.17.0 across GitHub Actions workflows.
  • Update Fedora 43 qemu and container test matrices to use Ansible Core 2.20 instead of 2.19.
  • Adjust container test job environment variables to avoid skipping requirements and callback plugins on the first test run, then skip them for subsequent runs to speed up execution.

…r fedora 43 [citest_skip]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner March 11, 2026 00:18
@richm richm self-assigned this Mar 11, 2026
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 11, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43, and adjusts container test environment variables to leverage the new tox-lsr behavior for faster, clearer container test runs.

Sequence diagram for updated CI container tests with tox-lsr 3.17.0 and Ansible 2.20

sequenceDiagram
    actor Developer
    participant GitHubActions
    participant ansible_test_job
    participant tox_lsr_3_17_0
    participant Fedora43_container
    participant Ansible_2_20

    Developer->>GitHubActions: Push commit / open PR
    GitHubActions->>ansible_test_job: Start ansible-test workflow
    ansible_test_job->>ansible_test_job: Checkout repository
    ansible_test_job->>tox_lsr_3_17_0: pip install tox-lsr 3.17.0
    ansible_test_job->>Fedora43_container: Start container test environment
    Fedora43_container->>Ansible_2_20: Install Ansible 2.20
    ansible_test_job->>tox_lsr_3_17_0: Invoke tox-lsr container test env
    tox_lsr_3_17_0->>Fedora43_container: Run tests with improved output
    Fedora43_container->>Ansible_2_20: Execute Ansible-based tests
    Ansible_2_20-->>Fedora43_container: Test results
    Fedora43_container-->>tox_lsr_3_17_0: Aggregated container test results
    tox_lsr_3_17_0-->>ansible_test_job: Faster, clearer test report
    ansible_test_job-->>GitHubActions: Job status
    GitHubActions-->>Developer: CI status and test logs
Loading

File-Level Changes

Change Details Files
Bump Ansible core version to 2.20 for Fedora 43 qemu and container test scenarios.
  • Update Fedora 43 qemu scenario to use qemu-ansible-core-2-20 environment instead of 2-19.
  • Update Fedora 43 container scenario to use container-ansible-core-2-20 environment instead of 2-19.
  • Update Fedora 43 bootc container scenario to use container-ansible-core-2-20 environment instead of 2-19.
.github/workflows/qemu-kvm-integration-tests.yml
Upgrade tox-lsr to version 3.17.0 across CI workflows.
  • Change tox-lsr installation in qemu-kvm-integration-tests workflow from 3.16.0 to 3.17.0.
  • Change tox-lsr installation in ansible-lint workflow from 3.16.0 to 3.17.0.
  • Change tox-lsr installation in ansible-managed-var-comment workflow from 3.16.0 to 3.17.0.
  • Change tox-lsr installation in ansible-test workflow from 3.16.0 to 3.17.0.
.github/workflows/qemu-kvm-integration-tests.yml
.github/workflows/ansible-lint.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/ansible-test.yml
Adjust container test loop to use tox-lsr 3.17.0 features for skipping requirements and callback plugins after the first test run.
  • Remove legacy LSR_CONTAINER_PROFILE and LSR_CONTAINER_PRETTY overrides from container test step.
  • Introduce SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS environment variables, forcing both to false before the first test.
  • Enable SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS after each test iteration to speed up subsequent runs while preserving full setup on the first run.
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant