ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox configuration to work with newer tox-lsr and revised qemu/container test environment naming.

CI:

• Rename qemu and container ansible-core tox environments in GitHub Actions from dot-based to dash-based version identifiers to avoid tox Python version conflicts.
• Bump tox-lsr version used in GitHub workflows from 3.15.0 to 3.16.0.

Documentation:

• Refresh contributing guide qemu tox example to use the new dash-based ansible-core environment name and updated version.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox-lsr version and renames qemu/container tox environments from dot-based ansible-core versions to dash-based ones to avoid tox 4.49 mis-parsing, plus refreshes the contributor qemu tox example.

Flow diagram for qemu tox env naming change

flowchart LR
  OldEnv["Old env name\nqemu-ansible-core-2.20"] --> ParseIssue["tox 4.49 mis-parses\n'2.20' as python 2.20"]
  ParseIssue --> Conflict["basepython conflict\nwith python 3.latest"]
  Conflict --> Rename["Rename envs to use dash\nqemu-ansible-core-2-20"]
  Rename --> NewEnv["New env name\nqemu-ansible-core-2-20"]
  NewEnv --> Fixed["No python version\nmis-parse in tox 4.49"]

Loading

File-Level Changes

Change	Details	Files
Rename qemu and container tox environments from major.minor to major-minor naming to avoid tox 4.49 python version parsing issues.	Adjust GitHub Actions qemu-kvm integration test matrix env names from qemu-ansible-core-X.Y to qemu-ansible-core-X-Y. Adjust container scenario env names from container-ansible-core-X.Y to container-ansible-core-X-Y, including commented examples. Ensure all matrix entries consistently use the new dash-based env naming convention.	.github/workflows/qemu-kvm-integration-tests.yml
Bump tox-lsr dependency used in CI workflows to version 3.16.0.	Update tox-lsr install version from 3.15.0 to 3.16.0 in qemu-kvm integration workflow. Update tox-lsr install version from 3.15.0 to 3.16.0 in ansible-lint workflow. Update tox-lsr install version from 3.15.0 to 3.16.0 in ansible-managed-var-comment workflow. Update tox-lsr install version from 3.15.0 to 3.16.0 in ansible-test workflow.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Align contributor documentation with the new qemu tox env naming scheme.	Change documented example tox invocation from qemu-ansible-core-2.14 to qemu-ansible-core-2-20 to demonstrate dash-based version naming in contributing guide.	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The example tox command in contributing.md now uses qemu-ansible-core-2-20, which doesn’t match any of the matrix environments (e.g. qemu-ansible-core-2-16); consider aligning the example with an actual defined env or clarifying that it’s just illustrative.
• Since the env names changed from major.minor to major-minor, it may be worth grepping the repo for qemu-ansible-core-2. and container-ansible-core-2. to ensure there are no remaining references to the old naming scheme in scripts or docs.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The example tox command in contributing.md now uses `qemu-ansible-core-2-20`, which doesn’t match any of the matrix environments (e.g. `qemu-ansible-core-2-16`); consider aligning the example with an actual defined env or clarifying that it’s just illustrative.
- Since the env names changed from `major.minor` to `major-minor`, it may be worth grepping the repo for `qemu-ansible-core-2.` and `container-ansible-core-2.` to ensure there are no remaining references to the old naming scheme in scripts or docs.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}