jbd2: update outdated comment for jbd2_journal_try_to_free_buffers()#1443
Open
vfsci-bot[bot] wants to merge 1 commit into
Open
jbd2: update outdated comment for jbd2_journal_try_to_free_buffers()#1443vfsci-bot[bot] wants to merge 1 commit into
vfsci-bot[bot] wants to merge 1 commit into
Conversation
jbd2_journal_try_to_free_buffers() currently only tries to remove checkpointed data buffers from the checkpoint list for data=journal mode, and bails out if any buffer is still attached to a transaction. For data=ordered and writeback modes, data buffers never have journal_heads, so the function degenerates to a plain try_to_free_buffers() call. Besides, The release of metadata buffers has been delegated to the jbd2 journal shrinker in commit 4ba3fcd ("jbd2,ext4: add a shrinker to release checkpointed buffers"). jbd2_journal_try_to_free_buffers() is not used for handling metadata buffers now. However, the comment above the function still references jbd2_journal_dirty_data(), __jbd2_journal_unfile_buffer(), t_datalist, BKL, and BUF_CLEAN, all of which were removed in commit 87c89c2 ("jbd2: Remove data=ordered mode support using jbd buffer heads"). Replace it with a description of what the function actually does now. Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Series: https://patchwork.kernel.org/project/linux-fsdevel/list/?series=1099117
Submitter: Zhang Yi
Version: 1
Patches: 1/1
Message-ID:
<20260522030540.3896201-1-yi.zhang@huaweicloud.com>Base: vfs.base.ci
Lore: https://lore.kernel.org/linux-fsdevel/20260522030540.3896201-1-yi.zhang@huaweicloud.com
Automated by ml2pr