ufs: Defensively handle NULL return from ufs_get_locked_folio()#1430
Open
vfsci-bot[bot] wants to merge 1 commit into
Open
ufs: Defensively handle NULL return from ufs_get_locked_folio()#1430vfsci-bot[bot] wants to merge 1 commit into
vfsci-bot[bot] wants to merge 1 commit into
Conversation
ufs_get_locked_folio() may return either an error pointer (when read_mapping_folio() fails) or NULL (when a concurrent truncate has detached the folio from its mapping). In ufs_alloc_lastblock() the NULL path cannot be reached in practice because the only caller, ufs_truncate(), holds i_rwsem and so serialises against other truncates. Still, the current IS_ERR()-only check does not match the documented contract of ufs_get_locked_folio() and is fragile against future callers. Use IS_ERR_OR_NULL() to match the helper's return contract. Signed-off-by: Ingyu Jang <ingyujang25@korea.ac.kr> Reviewed-by: Jan Kara <jack@suse.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Series: https://patchwork.kernel.org/project/linux-fsdevel/list/?series=1097181
Submitter: Ingyu Jang
Version: 2
Patches: 1/1
Message-ID:
<20260519085138.55591-1-ingyujang25@korea.ac.kr>Base: vfs.base.ci
Lore: https://lore.kernel.org/linux-fsdevel/20260519085138.55591-1-ingyujang25@korea.ac.kr
Automated by ml2pr