[RTAS]: Fix bug - remove fs scheme from tableLocation in commit (cont)#594
Merged
Conversation
cbb330
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the follow up PR of #542. After the fix, we were able to replace the table once but not multiple times. RC anslysis:
OpenHouseInternalTableOperationsusesmetadata.location()for the new HTS tableLocation, and that value comes from.withLocation(tableLocation)that we pass, so we need to make sure it's schemeless.tableDto.getTableVersion()to populate.withLocation(tableLocation), but tableDto always contains scheme. (Why is tableLocation = tableVersion in tableDto? Because tableVersion comes from client request, and client request uses the tableLocation from the server response, so they will always be same and contain scheme)Therefore, in this PR, we use the tableLocation from the table properties that we had just stripped in the last PR for
.withLocation(tableLocation).Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
Unit tests
I removed
stripPathSchemein the spark E2E tests to gurantee that scheme issues can be captured by unit tests.Test 1: RTAS
Test 2: CRTAS
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.