Add a USER_URL_PREFIX configuration option#95
Open
sangaline wants to merge 4 commits intolingthio:masterfrom
Open
Add a USER_URL_PREFIX configuration option#95sangaline wants to merge 4 commits intolingthio:masterfrom
sangaline wants to merge 4 commits intolingthio:masterfrom
Conversation
One wasn't used and the other should have been checking the query string for reg_next instead of next.
…gistration. It was previously not respected when USER_ENABLE_LOGIN_WITHOUT_CONFIRM_EMAIL and USER_AUTO_LOGIN_AFTER_REGISTER were both set to True.
Collaborator
|
Hi @sangaline! Thank you for your contribution! It looks super useful. Could you please rebase your branch over current master branch to resolve conflicts? |
and-semakin
reviewed
Nov 8, 2019
| return redirect(next) | ||
| # Redirect if USER_ENABLE_CONFIRM_EMAIL is set and they can't login yet | ||
| if user_manager.enable_confirm_email and require_email_confirmation and not user_manager.enable_login_without_confirm_email: | ||
| return redirect(reg_next) |
Collaborator
There was a problem hiding this comment.
I'm not sure if this things have to be in the same pull request with USER_URL_PREFIX. I would prefer to have a separate PR with this changes. Any way thank you! It looks useful too! 👍
and-semakin
added
the
Rebase Requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that it's a common use case that people want to put all of the user urls under another prefix other than '/user' (e.g. '/admin', '/'). Might it make sense to add a new config option that lets people change all of them at once instead of having to specify all 12 individually? The proposed implementation in this pull request would be backwards compatible while adding a small convenience for those wanting to specify a different url prefix.