You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jul 17, 2023. It is now read-only.
This adds the df_print argument to confluence_document() (cf. rmarkdown::output_format()), first and foremost to facilitate easy kable()/markdown output tables. df_print is passed down to rmarkdown::md_document().
Before I push this any further, would you be interested in this in general, @yutannihilation? Or is there a reason, this is not yet available?
Details:
The "paged" method is not possible, because it is not a valid format for markdown documents.
Arbitrary functions for printing data frames are not allowed ATM. They would have to generate a format that is markdown compatible and offer formatting that extents what is already possible with kable(). I would keep this out for now, but it could be added in a future iteration of the feature, of course.
df_print should probably be added as an option to the addin as well.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.
I am trying to add df_print to the addin as well. However, the md_document is already rendered when the addin window opens. So df_print is already set at that point and there is no way to change it, AFAIU (short of rendering the whole document again, which seems ... not ideal). Or am I missing something?
I'll leave df_print out of the addin then, because this would involve a fairly profound change to the addin AFAIU (open the addin before rendering the preview, trigger the preview after setting options, publish after reviewing the preview).
Sounds good to me. Most of the options of confluence_document() are used for controlling "how the document will be published," not customizing how the document is rendered, but df_print is the latter one. Sorry I didn't notice it at first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
df_printargument toconfluence_document()(cf.rmarkdown::output_format()), first and foremost to facilitate easykable()/markdown output tables.df_printis passed down tormarkdown::md_document().Before I push this any further, would you be interested in this in general, @yutannihilation? Or is there a reason, this is not yet available?
Details:
kable(). I would keep this out for now, but it could be added in a future iteration of the feature, of course.df_printshould probably be added as an option to the addin as well.