Conversation
- Remove unused eslint-disable directives in LineChart and LiveChart (console.warn inside production guard doesn't trigger no-console) - Add missing tick dep to useEffect in LiveValue and reorder hooks to avoid block-scoped variable reference before declaration - Add interpolatorsRef to useCallback deps in Chart hooks (refs are stable, no behavior change) - Remove unused CollectionProps interface from Autocomplete - Suppress intentional any in Combobox ValueProps render prop with inline eslint-disable explaining the design constraint Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Resolves rollup (4.57.1 → 4.59.0), ajv (6.12.6 → 6.14.0), and minimatch CVEs. Remaining 6 low-severity alerts are all elliptic via Storybook — no fix available without a breaking downgrade. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eslint-disabledirectives in Chart (LineChart, LiveChart)tickdependency to useEffect in LiveValue, reorder hooks to fix block-scoped referenceinterpolatorsRefto useCallback deps in Chart hooks (refs are stable, no behavior change)CollectionPropsinterface from Autocomplete (dead code)anyin ComboboxValuePropsrender prop with inline explanationResolves all 7 ESLint warnings from CI. Lint now reports 0 warnings, build passes clean.
Test plan
npm run lint— 0 errors, 0 warningsnpm run build— compiles and prerendered successfullyMade with Cursor