Add cryptoNetwork to realtimeFunding source object.#238
Add cryptoNetwork to realtimeFunding source object.#238
Conversation
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-typescript studio · code · diff
✅ grid-python studio · code · diff
✅ grid-openapi studio · code · diff
✅ grid-kotlin studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Greptile SummaryAdded
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/quotes/RealtimeFundingQuoteSource.yaml | Added cryptoNetwork field to specify blockchain network for stablecoin funding sources. Field properly documented with examples. |
| openapi.yaml | Generated bundle updated correctly with the new cryptoNetwork field from source schema. |
| mintlify/openapi.yaml | Documentation bundle updated correctly with the new cryptoNetwork field from source schema. |
Last reviewed commit: 9df5cf6
| cryptoNetwork: | ||
| type: string | ||
| description: >- | ||
| The crypto network to use for the funding source. Required when currency is a stablecoin (e.g. USDC, USDT). | ||
| Specifies which network the customer will deposit on, so the correct deposit address can be generated. | ||
| Example values: SOLANA_MAINNET, SOLANA_DEVNET, ETHEREUM_MAINNET. Note that sandbox platforms cannot use | ||
| MAINNET networks. | ||
| example: SOLANA_MAINNET |
There was a problem hiding this comment.
Check that documentation examples using REALTIME_FUNDING with stablecoins include cryptoNetwork:
mintlify/snippets/sending/cross-currency.mdx(line 174-178)mintlify/global-p2p/quickstart.mdx(line 145-149)
Both use "currency": "USDC" without cryptoNetwork, which the description states is required for stablecoins.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/quotes/RealtimeFundingQuoteSource.yaml
Line: 26-33
Comment:
Check that documentation examples using `REALTIME_FUNDING` with stablecoins include `cryptoNetwork`:
- `mintlify/snippets/sending/cross-currency.mdx` (line 174-178)
- `mintlify/global-p2p/quickstart.mdx` (line 145-149)
Both use `"currency": "USDC"` without `cryptoNetwork`, which the description states is required for stablecoins.
How can I resolve this? If you propose a fix, please make it concise.|
Missed that @kphurley7 already sent out #236 |

No description provided.