Skip to content

Add cryptoNetwork to realtimeFunding source object.#238

Closed
jklein24 wants to merge 1 commit intomainfrom
02-27-adding_cryptonetwork_to_the_externalaccountcreaterequest_and_externalaccount
Closed

Add cryptoNetwork to realtimeFunding source object.#238
jklein24 wants to merge 1 commit intomainfrom
02-27-adding_cryptonetwork_to_the_externalaccountcreaterequest_and_externalaccount

Conversation

@jklein24
Copy link
Contributor

No description provided.

@jklein24 jklein24 requested a review from shreyav February 27, 2026 23:41
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

✱ Stainless preview builds

This PR will update the grid SDKs with the following commit messages.

kotlin

feat(api): add cryptoNetwork field to RealtimeFundingQuoteSource

openapi

feat(api): add cryptoNetwork field to quote funding source

python

feat(api): add crypto_network field to realtime funding quote source

typescript

feat(api): add cryptoNetwork field to quotes RealtimeFundingSource

Edit this comment to update them. They will appear in their respective SDK's changelogs.

grid-typescript studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ✅test ✅

npm install https://pkg.stainless.com/s/grid-typescript/9712f4480cdb9ad5ab6c784c6b4c354068fde6e5/dist.tar.gz
grid-python studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ✅test ✅

pip install https://pkg.stainless.com/s/grid-python/4fa31d41eb9db6251ca95391fd683e8553ce6bda/grid-0.0.1-py3-none-any.whl
grid-openapi studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅

grid-kotlin studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ✅test ✅


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-02-27 23:49:26 UTC

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 27, 2026

Greptile Summary

Added cryptoNetwork field to the RealtimeFundingQuoteSource schema to specify which blockchain network should be used for stablecoin funding sources. The field is properly documented as required when using stablecoins like USDC or USDT, with example values for Solana, Ethereum networks.

  • Schema changes follow proper OpenAPI conventions with clear descriptions and examples
  • Generated bundles (openapi.yaml and mintlify/openapi.yaml) were correctly updated
  • Documentation examples using stablecoins with REALTIME_FUNDING should be checked to ensure they include the new field

Confidence Score: 4/5

  • Safe to merge with minor documentation follow-up recommended
  • The schema changes are straightforward and properly implemented. Generated files were correctly updated. Documentation examples should be verified to include the new field for stablecoin examples.
  • Check documentation examples in mintlify/snippets/sending/cross-currency.mdx and mintlify/global-p2p/quickstart.mdx to include the new cryptoNetwork field

Important Files Changed

Filename Overview
openapi/components/schemas/quotes/RealtimeFundingQuoteSource.yaml Added cryptoNetwork field to specify blockchain network for stablecoin funding sources. Field properly documented with examples.
openapi.yaml Generated bundle updated correctly with the new cryptoNetwork field from source schema.
mintlify/openapi.yaml Documentation bundle updated correctly with the new cryptoNetwork field from source schema.

Last reviewed commit: 9df5cf6

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment on lines +26 to +33
cryptoNetwork:
type: string
description: >-
The crypto network to use for the funding source. Required when currency is a stablecoin (e.g. USDC, USDT).
Specifies which network the customer will deposit on, so the correct deposit address can be generated.
Example values: SOLANA_MAINNET, SOLANA_DEVNET, ETHEREUM_MAINNET. Note that sandbox platforms cannot use
MAINNET networks.
example: SOLANA_MAINNET
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that documentation examples using REALTIME_FUNDING with stablecoins include cryptoNetwork:

  • mintlify/snippets/sending/cross-currency.mdx (line 174-178)
  • mintlify/global-p2p/quickstart.mdx (line 145-149)

Both use "currency": "USDC" without cryptoNetwork, which the description states is required for stablecoins.

Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/quotes/RealtimeFundingQuoteSource.yaml
Line: 26-33

Comment:
Check that documentation examples using `REALTIME_FUNDING` with stablecoins include `cryptoNetwork`:
- `mintlify/snippets/sending/cross-currency.mdx` (line 174-178)
- `mintlify/global-p2p/quickstart.mdx` (line 145-149)

Both use `"currency": "USDC"` without `cryptoNetwork`, which the description states is required for stablecoins.

How can I resolve this? If you propose a fix, please make it concise.

@jklein24
Copy link
Contributor Author

Missed that @kphurley7 already sent out #236

@jklein24 jklein24 closed this Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant