Skip to content

Harden SGLang decode training sample handling#107

Merged
yubofredwang merged 1 commit into
lightseekorg:mainfrom
mesaleh:fix/sgl-decode-training-min-tokens
May 25, 2026
Merged

Harden SGLang decode training sample handling#107
yubofredwang merged 1 commit into
lightseekorg:mainfrom
mesaleh:fix/sgl-decode-training-min-tokens

Conversation

@mesaleh
Copy link
Copy Markdown
Contributor

@mesaleh mesaleh commented May 24, 2026

Summary

  • add decode min_new_tokens and stop_token_ids config plumbing for SGLang decode-mode training
  • skip prompts that cannot leave room for the minimum generated tokens within max_seq_length
  • drop zero-loss completions and completions that begin with a configured stop token while preserving batch positions
  • make HFRunner an optional import so SGLang decode unit tests do not require Mooncake at import time

Testing

  • .venv/bin/python -m pytest tests/test_sgl_engine_decode.py -q

@yubofredwang yubofredwang merged commit 20c2f9c into lightseekorg:main May 25, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants