Move BOLT11 JIT params to payment metadata#899
Open
tnull wants to merge 3 commits intolightningdevkit:mainfrom
Open
Move BOLT11 JIT params to payment metadata#899tnull wants to merge 3 commits intolightningdevkit:mainfrom
tnull wants to merge 3 commits intolightningdevkit:mainfrom
Conversation
The values describe the `LSPS2` parameters negotiated for JIT-channel receives, not a fee-limit concept owned by the payment store. Rename the public type and internal references while preserving the existing fields, TLV encoding, and `PaymentKind::Bolt11Jit` storage shape for the follow-up refactor. Co-Authored-By: HAL 9000
`LSPS2Parameters` should travel with generated JIT invoices and the returned recipient onion metadata instead of living in a dedicated `PaymentKind::Bolt11Jit` payment-store variant. Store new JIT payments as `PaymentKind::Bolt11`, decode legacy `PaymentKind::Bolt11Jit` records as `PaymentKind::Bolt11`, and reject nonzero `counterparty_skimmed_fee_msat` unless valid BOLT11 `payment_metadata` proves the `LSPS2` fee is allowed. Co-Authored-By: HAL 9000
`PaymentDetails` field 1 only carried `LSPS2Parameters` in an unreleased intermediate layout before JIT data moved into `PaymentKind::Bolt11Jit`. Drop the stale reader path and compatibility fixture while keeping the released legacy `PaymentKind::Bolt11Jit` decoder intact. Co-Authored-By: HAL 9000
|
👋 Thanks for assigning @joostjager as a reviewer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We recently found that for the intended BOLT12-JIT flow we'll have to encode the LSPS2 parameters in the payment metadata (based on lightningdevkit/rust-lightning#4584). As a prefactor to that (and to simplify things for #811, rather than add yet another store type there, just to revert once we get to the BOLT12-JIT changes), we here switch to store the LSPS2 parameters in the BOLT11
payment_metadatarather than persisting them on-disk. To make this safe we'll also need lightningdevkit/rust-lightning#4528, as otherwise the payer could collude with the LSP to rob the payee.Summary
This moves LSPS2/JIT-channel receive parameters out of dedicated payment-store
state and into the BOLT11 invoice
payment_metadata, so the payment store nolonger needs a
PaymentKind::Bolt11Jitvariant for new payments.Changes
LSPFeeLimitstoLSPS2Parameters.Bolt11PaymentMetadatainbolt11.rswith TLV-based encoding.LSPS2Parametersinto BOLT11payment_metadatawhen creating JITinvoices.
PaymentKind::Bolt11.PaymentKind::Bolt11Jitrecords asPaymentKind::Bolt11.payment_metadataprovesthe LSPS2 fee is within the negotiated limit.
PaymentDetailsfield-1 JIT metadata reader, whilekeeping the released legacy
PaymentKind::Bolt11Jitdecoder.prior JIT state is not migrated.