Feat: Adds interactive-session resume#303
Merged
l-mansouri merged 69 commits intomainfrom Mar 26, 2026
Merged
Conversation
danielboloc
reviewed
Mar 25, 2026
Collaborator
danielboloc
left a comment
There was a problem hiding this comment.
thanks @l-mansouri, after re-testing I have some suggestions:
- Could you also add
awsWindowsSessionto the mapping and check if there are others missing?
- Could you change the
Tip:text to be yellow coloured like in the other command?
- Could you remove the empty whitespaces from the new implementation?
Collaborator
Author
|
@danielboloc Thanks for the comments:
|
Collaborator
|
Regarding number 3, I do not mean to remove all empty lines, which are good for reading the code, I meant to remove the leading indentation, like in my screenshot, there are 4 spaces at the beginning of the empty lines. As you mention, we should keep the empty lines for readability. |
Collaborator
Author
|
@danielboloc sorry, my bad for misinterpreting it. On it! |
danielboloc
approved these changes
Mar 26, 2026
Collaborator
danielboloc
left a comment
There was a problem hiding this comment.
thanks @l-mansouri
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Overview
This PR implements the resume functionality for interactive-session.
JIRA
LP-105731
Changes
Acceptance Criteria
Scenario 1: Successfully resume a paused IA session
Scenario 2: Resume a session with updated instance and resources
Scenario 3: Resume a session with mount data
Scenario 4: Attempt to resume a session that is already running
Scenario 5: Attempt to resume a session with a wrong session ID