Skip to content

Feat: Adds interactive-session resume#303

Merged
l-mansouri merged 69 commits intomainfrom
ia-resume
Mar 26, 2026
Merged

Feat: Adds interactive-session resume#303
l-mansouri merged 69 commits intomainfrom
ia-resume

Conversation

@l-mansouri
Copy link
Copy Markdown
Collaborator

@l-mansouri l-mansouri commented Mar 23, 2026

Overview

This PR implements the resume functionality for interactive-session.

JIRA

Please add here as many related tasks this PR covers with its brief description, if more than one ticket

LP-105731

Changes

  • Implements resume functionality for the interactive-session
  • Refactors docs

Acceptance Criteria

Please add here as many scenarios as in the Story

Normally this acceptance criteria is tested in ADAPT workspace in PROD

Scenario 1: Successfully resume a paused IA session Screenshot 2026-03-23 at 14 24 19
Scenario 2: Resume a session with updated instance and resources Screenshot 2026-03-23 at 14 38 06
Scenario 3: Resume a session with mount data Screenshot 2026-03-23 at 14 41 49
Scenario 4: Attempt to resume a session that is already running Screenshot 2026-03-23 at 14 29 32
Scenario 5: Attempt to resume a session with a wrong session ID Screenshot 2026-03-23 at 16 50 23

@l-mansouri l-mansouri marked this pull request as draft March 24, 2026 15:43
@l-mansouri l-mansouri marked this pull request as ready for review March 24, 2026 15:43
@l-mansouri l-mansouri marked this pull request as draft March 25, 2026 11:23
@l-mansouri l-mansouri marked this pull request as ready for review March 25, 2026 11:23
Copy link
Copy Markdown
Collaborator

@danielboloc danielboloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @l-mansouri, after re-testing I have some suggestions:

  1. Could you also add awsWindowsSession to the mapping and check if there are others missing?
Image
  1. Could you change the Tip: text to be yellow coloured like in the other command?
Image

Like:
Image

  1. Could you remove the empty whitespaces from the new implementation?
Image

@l-mansouri
Copy link
Copy Markdown
Collaborator Author

l-mansouri commented Mar 25, 2026

@danielboloc Thanks for the comments:

  1. Windows is not supported but done
  2. Done
  3. Those specific empty lines in the screenshot have been left there to identify easily the different exceptions. I have removed all the extra "empty" lines (more than 300 lines in the new implementation) but left some to make things easier to be found.

@l-mansouri l-mansouri marked this pull request as draft March 25, 2026 14:15
@l-mansouri l-mansouri marked this pull request as ready for review March 25, 2026 14:15
@danielboloc
Copy link
Copy Markdown
Collaborator

@l-mansouri

Regarding number 3, I do not mean to remove all empty lines, which are good for reading the code, I meant to remove the leading indentation, like in my screenshot, there are 4 spaces at the beginning of the empty lines. As you mention, we should keep the empty lines for readability.

Another example, with 8 leading spaces
image

@l-mansouri
Copy link
Copy Markdown
Collaborator Author

@danielboloc sorry, my bad for misinterpreting it. On it!

@l-mansouri l-mansouri marked this pull request as draft March 25, 2026 16:28
@l-mansouri l-mansouri marked this pull request as ready for review March 25, 2026 16:28
Copy link
Copy Markdown
Collaborator

@danielboloc danielboloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @l-mansouri

LGTM

@l-mansouri l-mansouri merged commit a57d449 into main Mar 26, 2026
214 of 218 checks passed
@l-mansouri l-mansouri deleted the ia-resume branch March 26, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants