Fix GCMouse scroll axis mapping on macOS#15376
Open
hollinsky wants to merge 1 commit intolibsdl-org:mainfrom
Open
Fix GCMouse scroll axis mapping on macOS#15376hollinsky wants to merge 1 commit intolibsdl-org:mainfrom
hollinsky wants to merge 1 commit intolibsdl-org:mainfrom
Conversation
The scroll valueChangedHandler was treating xValue as vertical and yValue as horizontal, copied from the iOS GCMouse implementation. On macOS, the GCControllerDirectionPad axes follow their documented semantics: xAxis (left/right) is horizontal and yAxis (up/down) is vertical. Swap the axis assignment so xValue maps to horizontal scroll and yValue maps to vertical scroll.
Contributor
|
Something to note: this doesn't respect the "natural scrolling" option in system settings, which is kind of unfortunate. I'm not familiar with these macOS APIs or what to do in this situation myself. Edit: actually, it seems like there are multiple issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scroll valueChangedHandler was treating xValue as vertical and yValue as horizontal, copied from the iOS GCMouse implementation. On macOS, the GCControllerDirectionPad axes follow their documented semantics: xAxis (left/right) is horizontal and yAxis (up/down) is vertical.
Swap the axis assignment so xValue maps to horizontal scroll and yValue maps to vertical scroll.
Tested on macOS 26.3.1, using both the internal trackpad of my MacBook Pro M1 Pro and a wireless USB mouse, and ultimately fixes scrolling for me in Dear ImGui.