Open
Conversation
ccawley2011
reviewed
Apr 13, 2026
Comment on lines
+191
to
+194
| systheme = SDL_SYSTEM_THEME_LIGHT; | ||
| if (SDL_SystemTheme_Init()) { | ||
| systheme = SDL_SystemTheme_Get(); | ||
| } |
Contributor
There was a problem hiding this comment.
Can SDL_GetSystemTheme() be used here instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Total revamp of the X11 fallback toolkit using a "driver" design.
This opens the door for Wayland/KMSDRM support, support for client side font rendering drivers (SDL_TTF, libfcft or even the built in debug font), etc
I ran it through Valgrind and only really found libdbus and xlib leaks, but if there are any of my own doing please let me know.
(New PR due to rebase, fixed keyboard navigation problems arising from ListAdd being used instead of ListAppend)