SDL_EnumerateDirectory(""): Don't append path separator if path is empty#15357
Open
Sackzement wants to merge 2 commits intolibsdl-org:mainfrom
Open
SDL_EnumerateDirectory(""): Don't append path separator if path is empty#15357Sackzement wants to merge 2 commits intolibsdl-org:mainfrom
Sackzement wants to merge 2 commits intolibsdl-org:mainfrom
Conversation
Contributor
Author
|
Refactored the code a bit. |
98ea6da to
6b01df1
Compare
6b01df1 to
798cc75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
SDL_EnumerateDirectory("")enumerates the root directory"/".Example code:
Output:
This is due to an appended path separator on an empty string here:
SDL/src/filesystem/posix/SDL_sysfsops.c
Lines 76 to 82 in ccf688c
This PR only appends the path separator if the path is not empty.
Outpt after change:
The changed code is not the prettiest, but a pretty fix would take more refactoring.
Ideas for a pretty fix are welcome.