iOS: Fix SDL_EVENT_DROP_FILE lost on cold start from URL open#15281
Open
jsm174 wants to merge 1 commit intolibsdl-org:mainfrom
Open
iOS: Fix SDL_EVENT_DROP_FILE lost on cold start from URL open#15281jsm174 wants to merge 1 commit intolibsdl-org:mainfrom
jsm174 wants to merge 1 commit intolibsdl-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Visual Pinball iOS app uses SDL main callbacks and a SwiftUI front end.
We use
SDL_EVENT_DROP_FILEbecause SwiftUI'sonopenurldoes not work when added to theSDL_uikitviewcontrollervia aUIHostingController.When the app is launched from a cold start, the event system isn't initialized, so the event gets dropped.
This PR fixes this by queueing up launch urls and then firing in
postFinishLaunch.Existing Issue(s)
#15093