Skip to content

perf: Avoid intermediate Vec when collecting TLDs in internal_compile #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rawk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: Avoid intermediate Vec when collecting TLDs in internal_compile #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions rasn-compiler/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,19 +492,14 @@ impl<B: Backend> Compiler<B, CompilerReady> {
let mut modules: Vec<ToplevelDefinition> = vec![];
for src in &self.state.sources {
let src_unit = src.try_into()?;
modules.append(
&mut asn_spec(src_unit)?
.into_iter()
.flat_map(|(header, tlds)| {
let header_ref = Rc::new(RefCell::new(header));
tlds.into_iter().map(move |mut tld| {
tld.apply_tagging_environment(&header_ref.borrow().tagging_environment);
tld.set_module_header(header_ref.clone());
tld
})
})
.collect(),
);
modules.extend(asn_spec(src_unit)?.into_iter().flat_map(|(header, tlds)| {
let header_ref = Rc::new(RefCell::new(header));
tlds.into_iter().map(move |mut tld| {
tld.apply_tagging_environment(&header_ref.borrow().tagging_environment);
tld.set_module_header(header_ref.clone());
tld
})
}));
}
let (valid_items, mut validator_errors) = Validator::new(modules).validate()?;
let modules = valid_items.into_iter().fold(
Expand Down
Loading