Skip to content

Instrument usage stack v10 alt #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lfittl wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Instrument usage stack v10 alt #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b5fe8da
instrumentation: Separate trigger logic from other uses
lfittl Mar 2, 2025
6e4e655
instrumentation: Separate per-node logic from other uses
lfittl Mar 7, 2026
ab7e538
instrumentation: Replace direct changes of pgBufferUsage/pgWalUsage w…
lfittl Mar 7, 2026
4733833
instrumentation: Add additional regression tests covering buffer usage
lfittl Feb 23, 2026
db2001a
Optimize measuring WAL/buffer usage through stack-based instrumentation
lfittl Sep 9, 2025
01bee21
instrumentation: Use Instrumentation struct for parallel workers
lfittl Mar 16, 2026
79c4489
instrumentation: Optimize ExecProcNodeInstr instructions by inlining
lfittl Mar 8, 2026
a53ec06
Index scans: Show table buffer accesses separately in EXPLAIN ANALYZE
lfittl Mar 7, 2026
55fc782
Add pg_session_buffer_usage contrib module
lfittl Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contrib/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ SUBDIRS = \
pg_overexplain \
pg_plan_advice \
pg_prewarm \
pg_session_buffer_usage \
pg_stat_statements \
pg_surgery \
pg_trgm \
Expand Down
22 changes: 3 additions & 19 deletions contrib/auto_explain/auto_explain.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,19 +305,9 @@ explain_ExecutorStart(QueryDesc *queryDesc, int eflags)

if (auto_explain_enabled())
{
/*
* Set up to track total elapsed time in ExecutorRun. Make sure the
* space is allocated in the per-query context so it will go away at
* ExecutorEnd.
*/
/* Set up to track total elapsed time in ExecutorRun. */
if (queryDesc->totaltime == NULL)
{
MemoryContext oldcxt;

oldcxt = MemoryContextSwitchTo(queryDesc->estate->es_query_cxt);
queryDesc->totaltime = InstrAlloc(1, INSTRUMENT_ALL, false);
MemoryContextSwitchTo(oldcxt);
}
queryDesc->totaltime = InstrQueryAlloc(INSTRUMENT_ALL);
}
}

Expand Down Expand Up @@ -381,14 +371,8 @@ explain_ExecutorEnd(QueryDesc *queryDesc)
*/
oldcxt = MemoryContextSwitchTo(queryDesc->estate->es_query_cxt);

/*
* Make sure stats accumulation is done. (Note: it's okay if several
* levels of hook all do this.)
*/
InstrEndLoop(queryDesc->totaltime);

/* Log plan if duration is exceeded. */
msec = INSTR_TIME_GET_MILLISEC(queryDesc->totaltime->total);
msec = INSTR_TIME_GET_MILLISEC(queryDesc->totaltime->instr.total);
if (msec >= auto_explain_log_min_duration)
{
ExplainState *es = NewExplainState();
Expand Down
1 change: 1 addition & 0 deletions contrib/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ subdir('pg_overexplain')
subdir('pg_plan_advice')
subdir('pg_prewarm')
subdir('pgrowlocks')
subdir('pg_session_buffer_usage')
subdir('pg_stat_statements')
subdir('pgstattuple')
subdir('pg_surgery')
Expand Down
23 changes: 23 additions & 0 deletions contrib/pg_session_buffer_usage/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# contrib/pg_session_buffer_usage/Makefile

MODULE_big = pg_session_buffer_usage
OBJS = \
$(WIN32RES) \
pg_session_buffer_usage.o

EXTENSION = pg_session_buffer_usage
DATA = pg_session_buffer_usage--1.0.sql
PGFILEDESC = "pg_session_buffer_usage - show buffer usage statistics for the current session"

REGRESS = pg_session_buffer_usage

ifdef USE_PGXS
PG_CONFIG = pg_config
PGXS := $(shell $(PG_CONFIG) --pgxs)
include $(PGXS)
else
subdir = contrib/pg_session_buffer_usage
top_builddir = ../..
include $(top_builddir)/src/Makefile.global
include $(top_srcdir)/contrib/contrib-global.mk
endif
Loading