Make sure SenderStatusCertMiss is not overwritten#5906
Open
eriknordmark wants to merge 1 commit intolf-edge:masterfrom
Open
Make sure SenderStatusCertMiss is not overwritten#5906eriknordmark wants to merge 1 commit intolf-edge:masterfrom
eriknordmark wants to merge 1 commit intolf-edge:masterfrom
Conversation
This is needed to fetch new controller certificates. Signed-off-by: eriknordmark <erik@zededa.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5906 +/- ##
==========================================
- Coverage 19.52% 17.10% -2.43%
==========================================
Files 19 474 +455
Lines 3021 85694 +82673
==========================================
+ Hits 590 14660 +14070
- Misses 2310 69517 +67207
- Partials 121 1517 +1396 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is needed to fetch new controller certificates. Without it certificate rotation can fail to propagate to
EVE devices in a timely manner (the 24 h timer will do it as a fallback).
Fixes the failures we see in the ctrl_cert_change test.
This was introduced in #5584 but the manual testing of those fixes always had a .bak file, and the eden smoke tests have had several cases of flaky tests preceeding the crtl_cert_change test so it has not been getting to the point of trying crtl_cert_change until recently.
How to test and validate this PR
Should be part of the normal regression testing, but in this case we need to run the manual
test which updates the controller signing certificate in addition to the eden test.
Changelog notes
None (part of the PR 5584)
PR Backports
MUST be backported where #5584 is backported wich is:
Checklist
I've provided a proper description
I've added the proper documentation
I've tested my PR on amd64 device
I've tested my PR on arm64 device
I've written the test verification instructions
I've set the proper labels to this PR
I've checked the boxes above, or I've provided a good reason why I didn't
check them.